feat(branch-protection): Push/Reviewer actors can be specified by name #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Added getNodeIDv4 feat(branch-protection): Added prefix requirement for teams/users The / prefix defines a user, the orgname/ prefix defines a team. (Ex.: testorg/team)
includes a nil check on branch protection resources
|
@kfcampbell Do you have any feedback on this? |
kfcampbell
reviewed
Oct 10, 2022
|
@kfcampbell I've made some changes with the feedback you gave, let me know if you have any more recommendations :) |
Also removed loop labels
kfcampbell
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Thanks for updating this! Integration tests for this branch protection resource are broken on the main branch and failing here as well with this error:
testing.go:705: Step 0 error: errors during apply:
Error: Could not resolve to a node with the global id of '1234'
on /tmp/tf-test2340247973/main.tf line 8:
(source code not available)
So I don't think this is a regression. Thank you for the contribution.
|
@dion-gionet Are you okay if I merge/release this PR today? |
|
@kfcampbell Yep, sounds good! |
Closed
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Oct 13, 2022
…d in integrations#1328 This reverts commit 553785b.
kfcampbell
added a commit
that referenced
this pull request
Oct 13, 2022
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
integrations#1020) * feat(branch-protection): Push/Reviewer actors can be specified by name feat: Added getNodeIDv4 feat(branch-protection): Added prefix requirement for teams/users The / prefix defines a user, the orgname/ prefix defines a team. (Ex.: testorg/team) * test(branch-protection): Added push restriction test with username * doc(branch-protection): Updated documentation to mention actor names * feat(branch-protection): updated to latest version * fix: env nil pointer dereference includes a nil check on branch protection resources * fix(branch-protection): added error handling Also removed loop labels
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
…d in integrations#1328 (integrations#1330) This reverts commit 553785b.
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
integrations#1020) * feat(branch-protection): Push/Reviewer actors can be specified by name feat: Added getNodeIDv4 feat(branch-protection): Added prefix requirement for teams/users The / prefix defines a user, the orgname/ prefix defines a team. (Ex.: testorg/team) * test(branch-protection): Added push restriction test with username * doc(branch-protection): Updated documentation to mention actor names * feat(branch-protection): updated to latest version * fix: env nil pointer dereference includes a nil check on branch protection resources * fix(branch-protection): added error handling Also removed loop labels
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…d in integrations#1328 (integrations#1330) This reverts commit 03bc539.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the github_branch_protection resource.
This enables us to use the branch protection resource without using a data block just to retrieve the node ID for users/teams. Node IDs can still be used as an input but you can now use a prefix to define a username or team name
The / prefix defines a user (Ex.: /testuser), the orgname/ prefix defines a team. (Ex.: testorg/team)