Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for allow_forking on a repository/update to go-github v42 #1033

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Support for allow_forking on a repository/update to go-github v42 #1033

merged 7 commits into from
Apr 28, 2022

Conversation

diogopms
Copy link
Contributor

@diogopms diogopms commented Jan 13, 2022

Support enabling/disabling allow_forking on a repository as per #353
More info on the Github Public API
image

Waiting from go-github to create a release on this PR:

google/go-github#2256

@diogopms diogopms marked this pull request as draft January 13, 2022 15:35
@diogopms diogopms marked this pull request as ready for review January 13, 2022 16:16
@diogopms diogopms changed the title Support for allow_forking on a repository Support for allow_forking on a repository/update to go-github v42 Jan 13, 2022
@kfcampbell kfcampbell added this to the v4.24.0 milestone Mar 22, 2022
@kfcampbell
Copy link
Member

@diogopms I've merged the latest main in, and chosen to default allow_forking to true, which I believe matches the behavior shown in the API docs you linked above.

Are you okay with these changes as-is? If so, I can get them merged. If not, let's talk about it!

@kfcampbell kfcampbell modified the milestones: v4.24.0, v4.25.0 Apr 8, 2022
@diogopms
Copy link
Contributor Author

diogopms commented Apr 19, 2022

👍🏻 looks good let's merge it , thanks for fixing it 🙏🏻 cc @kfcampbell

@jaredfholgate
Copy link

@kfcampbell and @diogopms This change is exhibiting odd behaviour and may need to be fixed or reverted. As per issue #1136. Also, for some reason the website docs have not been updated to reflect this new field, even though they are changed in this push. Happy to help if I can?

@kfcampbell
Copy link
Member

@jaredfholgate I've reverted this PR and published v4.24.1 with only that change in it. If you'd like to take a stab at fixing the behavior, I'd be happy to review it!

kfcampbell added a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…tegrations#1033)

* updating go-github to v42

* support for allow_forking field

* Make allow_forking optional; default to true

* Default allow_forking to true in resource

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
@martinm82
Copy link

What would be the desired behaviour? Should the implementation first check whether forking has been disabled on org level and in such a case do nothing? Is that feasible? I am not familiar with this provider but would really like to have the allow_forking support in the provider.

kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
…tegrations#1033)

* updating go-github to v42

* support for allow_forking field

* Make allow_forking optional; default to true

* Default allow_forking to true in resource

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants