Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a data source for branch protection rules. #1207

Merged
merged 10 commits into from
May 5, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jun 28, 2022

Resolves #1206

Description

This PR adds a data source for branch protection rules. Given a repository name, it returns a list of branch protection rules associated with that repository.

I added a markdown entry which describes how to configure the new data source.

Testing
  • TF_ACC=1 go test -v ./... -run ^ TestAccGithubBranchProtectionRulesDataSource

@galargh galargh changed the title Add a data source for branch protection rules. feat: Add a data source for branch protection rules. Apr 4, 2023
@kfcampbell
Copy link
Member

@galargh sorry I missed this; is this still a feature you're interested in getting shipped?

@othmane399
Copy link

Hello @kfcampbell, this PR is stale for a moment ? can you look at it please ? I can eventually fork and fix what needed to make it merge :)

@galargh
Copy link
Contributor Author

galargh commented Apr 24, 2023

@galargh sorry I missed this; is this still a feature you're interested in getting shipped?

Hey! Thanks for the reply :) Yes, I still think it'd be nice to have. It's not a strict requirement for my use cases anymore though.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the added integration tests are passing. Thank you for contributing!

@othmane399
Copy link

Hey @kfcampbell sorry for disturbing can we merge this PR then ? 🙏

@kfcampbell kfcampbell merged commit 0daadfa into integrations:main May 5, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
* Add a data source for branch protection rules.

* chore: go fmt

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a data source for retrieving branch protection rules for repository.
3 participants