Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add data source to read secrets #1245

Merged
merged 8 commits into from
Sep 16, 2022

Conversation

bpaquet
Copy link
Contributor

@bpaquet bpaquet commented Jul 31, 2022

No description provided.

@bpaquet bpaquet changed the title Add github_actions_secrets [Feature] Add data source to read secrets Jul 31, 2022
@bpaquet
Copy link
Contributor Author

bpaquet commented Sep 6, 2022

@kfcampbell Any way to review this ? Thx

@kfcampbell
Copy link
Member

Does github/data_source_github_actions_secrets.go track repository-level secrets? It's not immediately clear to me how that's different from organization secrets and dependabot secrets.

@bpaquet
Copy link
Contributor Author

bpaquet commented Sep 12, 2022

Does github/data_source_github_actions_secrets.go track repository-level secrets? It's not immediately clear to me how that's different from organization secrets and dependabot secrets.

Yes it is. I followed the naming we already have on resources.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 9e522d6 into integrations:main Sep 16, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
* Add github_actions_secrets

* Update sdk version

* Improve doc

* Fix merge

* Reorder github.erb for alphabetization (is that a word?)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
* Add github_actions_secrets

* Update sdk version

* Improve doc

* Fix merge

* Reorder github.erb for alphabetization (is that a word?)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants