Set LDAP DN on team creation

[jMarkP]

Set LDAPDN on the NewTeam on creation, if it's not the empty string. This avoids an extra call to the GHE API, but more importantly means the user does not need to be a site admin to create a team with LDAP sync

Resolves #1490

---

Behavior

Before the change?

• The provider used to call client.Teams.CreateTeam() and then follow up with client.Admin.UpdateTeamLDAPMapping()
• As well as being another call to the API, this requires that the user has the site_admin scope, but this is not required if the LDAP mapping is set on team creation

After the change?

• Now the LDAPDN field is set in the call to client.Teams.CreateTeam() and the second call has been removed

Other information

• This does introduce a potential imbalance for users who don't have site admin. They will be able to create a github_team resource with an LDAP mapping, but won't be able to update that mapping in the future. I'm not sure whether that's a blocker to this or not. Happy to hear your thoughts.
• I've not added tests. There are no tests for LDAP mappings at the moment, and I presume it would be difficult to add to the test suite without access to a GHE appliance setup with AD integration.

---

Additional info

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes (Please add the Type: Breaking change label)
• No

If Yes, what's the impact:

• N/A

Pull request type

Please add the corresponding label for change this PR introduces:

• Bugfix: Type: Bug
• Feature/model/API additions: Type: Feature
• Updates to docs or samples: Type: Documentation
• Dependencies/code cleanup: Type: Maintenance

---

[kfcampbell]

@jMarkP should the same change be replicated across to the "Update" function as well?

[jMarkP]

@jMarkP should the same change be replicated across to the "Update" function as well?

Unfortunately the team update endpoint doesn't seem to allow you to update the LDAP DN of a team: https://docs.github.com/en/enterprise-server@3.5/rest/teams/teams#update-a-team

You have to use the Update LDAP mapping admin endpoint which is what the update function already does

[kfcampbell]

Ahh understood, thank you!

Integration tests are passing for me locally on both main and this branch.

[jMarkP]

Thanks for the merge @kfcampbell !