Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates to fix broken builds #1547

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Dependency updates to fix broken builds #1547

merged 4 commits into from
Feb 13, 2023

Conversation

kfcampbell
Copy link
Member

I'd like to make sure we're using the latest version of Go before continuing to troubleshoot #1535.

Behavior

Before the change?

  • The standard CI check uses Go 1.19

After the change?

  • The standard CI check uses Go 1.20

Other information

  • N/A

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 13, 2023
@kfcampbell kfcampbell changed the title Switch to Go 1.20 in normal CI Dependency updates to fix broken builds Feb 13, 2023
@kfcampbell kfcampbell merged commit 9cf65a4 into main Feb 13, 2023
@kfcampbell kfcampbell deleted the go1.20-in-ci branch February 13, 2023 22:42
reedloden pushed a commit to reedloden/terraform-provider-github that referenced this pull request Jun 14, 2023
@kfcampbell @reedloden
Dependency updates to fix broken builds (integrations#1547)
791ab32 
* Switch to Go 1.20 in normal CI

* Get latest version of golangci-lint

* Remove outdated linters

* Use explicit version of client9/misspell
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@kfcampbell
Dependency updates to fix broken builds (integrations#1547)
f35ec8f 
* Switch to Go 1.20 in normal CI

* Get latest version of golangci-lint

* Remove outdated linters

* Use explicit version of client9/misspell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kfcampbell