Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Organization-level public key data sources #1608

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Mar 20, 2023

Add the following new data sources:

  • github_actions_organization_public_key
  • github_dependabot_organization_public_key

Resolves #1607


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Add the following new data sources:
* github_actions_organization_public_key
* github_dependabot_organization_public_key
@bodgit
Copy link
Contributor Author

bodgit commented Mar 20, 2023

$ TF_ACC=1 go test -v ./... -run ^TestAccGithub.*OrganizationPublicKeyDataSource
?       github.com/integrations/terraform-provider-github/v5    [no test files]
=== RUN   TestAccGithubActionsOrganizationPublicKeyDataSource
=== RUN   TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error
=== RUN   TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_anonymous_account
    data_source_github_actions_organization_public_key_test.go:37: anonymous account not supported for this operation
=== RUN   TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_individual_account
    data_source_github_actions_organization_public_key_test.go:41: individual account not supported for this operation
=== RUN   TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_organization_account
--- PASS: TestAccGithubActionsOrganizationPublicKeyDataSource (2.94s)
    --- PASS: TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error (2.94s)
        --- SKIP: TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubActionsOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_organization_account (2.94s)
=== RUN   TestAccGithubDependabotOrganizationPublicKeyDataSource
=== RUN   TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error
=== RUN   TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_anonymous_account
    data_source_github_dependabot_organization_public_key_test.go:37: anonymous account not supported for this operation
=== RUN   TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_individual_account
    data_source_github_dependabot_organization_public_key_test.go:41: individual account not supported for this operation
=== RUN   TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_organization_account
--- PASS: TestAccGithubDependabotOrganizationPublicKeyDataSource (2.84s)
    --- PASS: TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error (2.84s)
        --- SKIP: TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubDependabotOrganizationPublicKeyDataSource/queries_an_organization_public_key_without_error/with_an_organization_account (2.84s)
PASS
ok      github.com/integrations/terraform-provider-github/v5/github     (cached)

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the newly-added integration tests are passing for me. Thank you for contributing!

@kfcampbell kfcampbell merged commit 0546397 into integrations:main Apr 3, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Add the following new data sources:
* github_actions_organization_public_key
* github_dependabot_organization_public_key

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add Organization data sources for Actions and Dependabot public keys
2 participants