Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fork attribute to github_repository data #1647

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

davidcorrigan714
Copy link
Contributor

@davidcorrigan714 davidcorrigan714 commented Apr 12, 2023

Behavior

  • Adds the fork attribute to the github_repository data.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

  • Feature/model/API additions: Type: Feature

@davidcorrigan714
Copy link
Contributor Author

Don't think I can add the label myself to the PR.

@kfcampbell kfcampbell added the Type: Feature New feature or request label Apr 14, 2023
@kfcampbell
Copy link
Member

Would you mind adding relevant test cases to the existing tests in github/data_source_github_repository_test.go?

@davidcorrigan714
Copy link
Contributor Author

Ooops, saw those and totally forgot to add it in.

@davidcorrigan714
Copy link
Contributor Author

Added a test. I don't see a way to create a fork through Terraform but at least it tests that it's readable. Though the property is read in all the tests so it'd fail elsewhere too if it was really an issue.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 89aa2c5 into integrations:main Apr 14, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants