Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer in runner group if not modified #1696

Merged
merged 1 commit into from
May 24, 2023

Conversation

dbaur
Copy link
Contributor

@dbaur dbaur commented May 24, 2023

Resolves #1524


Behavior

Before the change?

  • reading the github_actions_runner_group will lead to a nil pointer exception if the API returns a 304 not modified response

After the change?

  • the read method will return early (not setting the attributes on the schema) if the resource is not modified

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dbaur for the contribution here! ❤️

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label May 24, 2023
@nickfloyd nickfloyd merged commit 35a4e99 into integrations:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] github_actions_runner_group: invalid memory address or nil pointer dereference
2 participants