feat: Add GitHub Organization Custom Role Resource and Data Source

[cailen]

Resolves #1069

---

Behavior

Before the change?

• There was no ability to create custom roles in GitHub Organizations.

After the change?

• You can create and manage custom roles
• You can refer to them in a data source

Other information

N/A

---

Additional info

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)

  • Data Source:

  TF_ACC=1 go test -v ./... -run TestAccGithubOrganizationCustomRoleDataSource
    --- PASS: TestAccGithubOrganizationCustomRoleDataSource (7.03s)
    --- PASS: TestAccGithubOrganizationCustomRoleDataSource/queries_a_custom_repo_role (7.03s)
        --- SKIP: TestAccGithubOrganizationCustomRoleDataSource/queries_a_custom_repo_role/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationCustomRoleDataSource/queries_a_custom_repo_role/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubOrganizationCustomRoleDataSource/queries_a_custom_repo_role/with_an_organization_account (7.03s)
        PASS
        ok      github.com/integrations/terraform-provider-github/v5/github     7.958s
  

  • Resource:

  TF_ACC=1 go test -v ./... -run TestAccGithubOrganizationCustomRole
     --- PASS: TestAccGithubOrganizationCustomRole (16.99s)
    --- PASS: TestAccGithubOrganizationCustomRole/creates_custom_repo_role_without_error (4.27s)
        --- SKIP: TestAccGithubOrganizationCustomRole/creates_custom_repo_role_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationCustomRole/creates_custom_repo_role_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubOrganizationCustomRole/creates_custom_repo_role_without_error/with_an_organization_account (4.27s)
    --- PASS: TestAccGithubOrganizationCustomRole/updates_custom_repo_role_without_error (8.30s)
        --- SKIP: TestAccGithubOrganizationCustomRole/updates_custom_repo_role_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationCustomRole/updates_custom_repo_role_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubOrganizationCustomRole/updates_custom_repo_role_without_error/with_an_organization_account (8.30s)
    --- PASS: TestAccGithubOrganizationCustomRole/imports_custom_repo_role_without_error (4.42s)
        --- SKIP: TestAccGithubOrganizationCustomRole/imports_custom_repo_role_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubOrganizationCustomRole/imports_custom_repo_role_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubOrganizationCustomRole/imports_custom_repo_role_without_error/with_an_organization_account (4.42s)
        PASS
        ok      github.com/integrations/terraform-provider-github/v5/github     24.637s
  

• Docs have been reviewed and added / updated if needed (for bug fixes / features)

• Added the appropriate label for the given change

Does this introduce a breaking change?

I do not believe so.

Please see our docs on breaking changes to help!

• Yes (Please add the Type: Breaking change label)
• No

If Yes, what's the impact:

• N/A

Pull request type

• Feature/model/API additions: Type: Feature
• Updates to docs or samples: Type: Documentation

---

[kfcampbell]

Confirming that the added integration tests are passing for me. Thank you for contributing!

[kfcampbell]

Sorry about the delay here; this slipped through the cracks for me somehow. I'll get this merged and released soon!

[usmonster]

Sorry to comment on an old/merged PR, but is this a necessary constraint? The API permits creation of a repository role without additional permissions, and it makes perfect sense if the role's only purpose is to designate who can bypass a repository ruleset, for example:

gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /orgs/$ORG/custom-repository-roles \
  -f name='rule-breaker' \
  -f description='Can bypass repository rulesets' \
  -f base_role='read' \
  -f "permissions[]" 

If you can confirm, shall I open another issue (or PR) to correct this? Thanks!

[cailen]

I believe you may be right about this. I was however unable to get it to post to the API at the time, so I was thinking it did require something, but I may have just passed in the wrong blank value.