[v0.12-beta2] Bump go-github version v24 #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After bumping to go-github v24, a couple of signatures have changed. One of them, the `name` on `webhooks` has been removed. Previously, the only valid name was `web`, and now, it has been removed from the object. This commit is a breaking change on the provider, as it will not accept more taking `name` on the webhook resources.
ghost
added
the
This was referenced Apr 24, 2019
|
@apparentlymart It would also be nice to land this change before doing the compatibility release. The previous Sorry to keep bothering and thanks a lot for the help recently. Let me know who would be better fit to ping on such issues as well. |
|
@bltavares I'm working on these, as well as #181 and adding 0.12 support. Hopefully should have this ready to go soon, really appreciate your work here! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bumping to go-github v24, a couple of signatures have changed.
One of them, the
nameonwebhookshas been removed. Previously, theonly valid name was
web, and now, it has been removed from the object.This PR is a breaking change on the provider, as it will not accept
more taking
nameon the webhook resources.