docs: mark enterprise runner visibility required #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `visibility` property is not specified on the `github_enterprise_actions_runner_group`, an error is thrown.
kfcampbell
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Our API docs show that this is actually optional, so the required piece is an implementation detail from this repository that could be relaxed. The smart thing to do would be to make that optional in our code.
However, this is a good step in the meantime that corrects the docs error. Thanks!
kireque
referenced
this pull request
in kireque/home-ops
Jul 9, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | patch | `6.2.2` -> `6.2.3` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v6.2.3`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v6.2.3) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v6.2.2...v6.2.3) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🛠️ Maintenance - build(deps): bump the github-actions group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2303](https://togithub.com/integrations/terraform-provider-github/pull/2303) ##### 🏷 Other Changes - fix: Fixing `enterprise_id` import on `github_enterprise_actions_permissions` by [@​ErikElkins](https://togithub.com/ErikElkins) in [https://github.com/integrations/terraform-provider-github/pull/2274](https://togithub.com/integrations/terraform-provider-github/pull/2274) - Bump go-github to v62 + fixes by [@​EttoreFoti](https://togithub.com/EttoreFoti) in [https://github.com/integrations/terraform-provider-github/pull/2304](https://togithub.com/integrations/terraform-provider-github/pull/2304) - docs: mark enterprise runner visibility required by [@​gustavlasko](https://togithub.com/gustavlasko) in [https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278) #### New Contributors - [@​gustavlasko](https://togithub.com/gustavlasko) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2278](https://togithub.com/integrations/terraform-provider-github/pull/2278) **Full Changelog**: integrations/terraform-provider-github@v6.2.2...v6.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
visibilityproperty is not specified on thegithub_enterprise_actions_runner_group, an error is thrown.Pull request checklist
Does this introduce a breaking change?
Nope!
Please see our docs on breaking changes to help!