-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: support repository_custom_properties resource and datasource #2316
base: main
Are you sure you want to change the base?
WIP: support repository_custom_properties resource and datasource #2316
Conversation
@felixlut It seems that v64 google/go-github#3240 added support for Multi select finally. Only issue is that the terraform provider codebase is still at v63 |
Seems like #2359 will deal with bumping the dep, so I'll revisit this once it's merged |
I started looking into this again over the weekend but hit a bottleneck again. I made a fix in google/go-github#3309, but that requires another bump of the The reason I'd rather use that than the |
Resolves #1956 (doesn't resolve that whole issue, but contributes to it)
Custom properties are defined on an organizational level, and then applied on a repository level. This PR aims to solve the latter of those two, while the former already has a PR for it in #2107.
This is a work in progress (WIP) since the underlying sdk:s are lacking for the REST endpoints pertaining to the repository level custom properties:
go-github
lacks support for themulti_select
custom property type, see Bug: Multi-select Custom Properties are not supported google/go-github#3198. There is a PR close to being merged for solving this feat!: Add support for multi-select Custom Properties google/go-github#3200go-github
has been released sincegithub_repository_custom_properties
datasource with it due to the lacking functionality ofgo-github
in this area currently. I'm currently trying to get it to write the custom properties, which I've been unsuccessful in so far. See [BUG]: PATCH request for repos/OWNER/REPO/properties/values broken octokit/go-sdk#90github_repository_custom_properties
datasource togithub_repository_custom_property
(notice propertIES --> propertY), which fetches a specific property instead of all of them after discussion in 🏳️ Custom properties resource & data #2107 (comment)If there's any progress on either of these I'll update this PR
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!