Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent a panic when trying to use DismissalRestrictions #385

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Prevent a panic when trying to use DismissalRestrictions #385

merged 1 commit into from
Mar 25, 2020

Conversation

svanharmelen
Copy link
Contributor

@svanharmelen svanharmelen commented Mar 13, 2020 •
edited
Loading

The recently updated go-github package updated the protections struct
a little by converting the DismissalRestrictions field from a struct
to a pointer to a struct. Hence this can now be nil which in turn
causes a panic when trying to use it as a value.

This PR added the change to the go-github package: google/go-github#1288

Relevant crash info:

panic: runtime error: invalid memory address or nil pointer dereference
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xe0e67c]
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: goroutine 95 [running]:
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: github.com/terraform-providers/terraform-provider-github/github.flattenAndSetRequiredPullRequestReviews(0xc0002724d0, 0xc00022cce0, 0x0, 0x0)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/github/resource_github_branch_protection.go:431 +0x4c
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: github.com/terraform-providers/terraform-provider-github/github.resourceGithubBranchProtectionRead(0xc0002724d0, 0xec62c0, 0xc00016e630, 0xc0002724d0, 0x0)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/github/resource_github_branch_protection.go:241 +0x9a7
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: github.com/hashicorp/terraform/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc000116b80, 0xc00009a820, 0xec62c0, 0xc00016e630, 0xc0001362a0, 0x0, 0x0)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/github.com/hashicorp/terraform/helper/schema/resource.go:455 +0x11c
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: github.com/hashicorp/terraform/helper/plugin.(*GRPCProviderServer).ReadResource(0xc00000ca90, 0x12b5f20, 0xc00065b2c0, 0xc000250000, 0xc00000ca90, 0xc00065b230, 0xf74120)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/github.com/hashicorp/terraform/helper/plugin/grpc_provider.go:525 +0x3a8
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: github.com/hashicorp/terraform/internal/tfplugin5._Provider_ReadResource_Handler(0x10a07c0, 0xc00000ca90, 0x12b5f20, 0xc00065b2c0, 0xc00009bf90, 0x0, 0x0, 0x0, 0xc00025d040, 0x195)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/github.com/hashicorp/terraform/internal/tfplugin5/tfplugin5.pb.go:3181 +0x23e
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: google.golang.org/grpc.(*Server).processUnaryRPC(0xc000144780, 0x12bc280, 0xc000145200, 0xc0005fb000, 0xc0001263c0, 0x1af6c50, 0x0, 0x0, 0x0)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/google.golang.org/grpc/server.go:971 +0x4a2
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: google.golang.org/grpc.(*Server).handleStream(0xc000144780, 0x12bc280, 0xc000145200, 0xc0005fb000, 0x0)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/google.golang.org/grpc/server.go:1250 +0xd61
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc000034510, 0xc000144780, 0x12bc280, 0xc000145200, 0xc0005fb000)
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/google.golang.org/grpc/server.go:690 +0x9f
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: created by google.golang.org/grpc.(*Server).serveStreams.func1
2020-03-13T11:26:01.255Z [DEBUG] plugin.terraform-provider-github_v2.4.1_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-github/vendor/google.golang.org/grpc/server.go:688 +0xa1
2020-03-13T11:26:01.256Z [DEBUG] plugin: plugin process exited: path=/terraform/.terraform/plugins/linux_amd64/terraform-provider-github_v2.4.1_x4 pid=1664 error="exit status 2"

@svanharmelen
Prevent a panic when trying to use DismissalRestrictions
66a4285 
The recently updated `go-github` package updated the protections struct
a little by converting the `DismissalRestrictions` field from a struct
to a pointer to a struct. Hence this can now be `nil` which in turn
causes a panic when trying to use it as a value.

This PR added the change to the `go-github` package: google/go-github#1288
@ghost ghost added the size/S label Mar 13, 2020
@jcudit jcudit added Type: Bug Something isn't working as documented crash Good first issue Good for newcomers Status: Up for grabs Issues that are ready to be worked on by anyone labels Mar 18, 2020
@jcudit jcudit merged commit 7f646ab into integrations:master Mar 25, 2020
@anGie44 anGie44 mentioned this pull request Mar 25, 2020
Closed
@jcudit jcudit added this to the v2.5.0 milestone Mar 27, 2020
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Merge pull request integrations#385 from svanharmelen/svh/b-branch-pr…
0bb8e92 
…otection

Prevent a panic when trying to use DismissalRestrictions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit approved these changes

Assignees
No one assigned
Labels
Good first issue Good for newcomers size/S Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@svanharmelen @jcudit