Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Visibility" #452

Merged
merged 1 commit into from
May 10, 2020
Merged

Revert "Visibility" #452

merged 1 commit into from
May 10, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 10, 2020

Reverts terraform-providers/terraform-provider-github#441

  • introduces a breaking change (default value of false will be applied and override private param if visibility is omitted in config)
  • will re-open Visibility #441 for changes

@ghost ghost added size/S Type: Documentation Improvements or additions to documentation labels May 10, 2020
@anGie44 anGie44 closed this May 10, 2020
@anGie44 anGie44 deleted the revert-441-visibility branch May 10, 2020 18:00
@anGie44 anGie44 restored the revert-441-visibility branch May 10, 2020 18:10
@anGie44 anGie44 reopened this May 10, 2020
@anGie44 anGie44 merged commit 91fc6ed into master May 10, 2020
@anGie44 anGie44 deleted the revert-441-visibility branch May 10, 2020 18:12
@harlowja
Copy link

This is scary :(

@harlowja
Copy link

Thanks for the revert. eck...

kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants