Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pagination to retrieve all team members #702

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Use pagination to retrieve all team members #702

merged 1 commit into from
Mar 4, 2021

Conversation

adebasi
Copy link
Contributor

@adebasi adebasi commented Feb 12, 2021

This PR addresses the issue: #701

When using the data source github_team a maximum of 30 members is retrieved. With this change, the per_page value gets increased to 100 and pagination is used to get all team members.

@adebasi adebasi changed the title Increase per page items for team members to 100 Use pagination to retrieve all team members Feb 14, 2021
Copy link
Contributor

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for speeding this up for everyone.

@jcudit jcudit merged commit fc85191 into integrations:master Mar 4, 2021
@jcudit jcudit added this to the v4.6.0 milestone Mar 4, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants