Fix branch protection import by repository node ID and pattern #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an existing test for importing by <repo-name>:<pattern>, but not a test for <repo-node-id>:<pattern>.
Importing a branch protection rule by an ID of the form <repo-node-id>:<pattern> was broken. Closes: integrations#671
jcudit
approved these changes
Mar 1, 2021
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…rations#713) * Add test for importing github_branch_protection There was an existing test for importing by <repo-name>:<pattern>, but not a test for <repo-node-id>:<pattern>. * Fix importing github_branch_protection Importing a branch protection rule by an ID of the form <repo-node-id>:<pattern> was broken. Closes: integrations#671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing github_branch_protection using an ID of the form
<repo-node-id>:<pattern>was broken, because the repository node ID was used as a repository name in the GraphQL query to fetch the branch protection rule.I've updated the tests so that there is now an import test for both both ways of importing branch protection rules (
<repo-name>:<pattern>and<repo-node-id>:<pattern>).Closes: #671