add proxied field to ias attestation_method too for attesteer rpc #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
reviewed
Aug 8, 2023
|
I thought about this, but there's a whole set of upgrades in consequence, through multiple repositories. If this PR stays the only breaking change, I'd rather save that time because this feature is unrequested |
|
IAS is discontinued anyway. we can drop this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216
this is a state breaking change. not sure when to merge
without this PR, IAS attestation through attesteer rpc will fail because the enclave signer isn't the sender of the registration extrinsic