Improve XCM Config #131
Improve XCM Config #131
Conversation
- Remove ParentAsSuperuser from XCM origin converter - Disallow generic XCM execution, do not allow teleport and allow transfer
echevrier
force-pushed
the
ec_xcm_filter_117
branch
from
70a83e7
to
be2b9c6
Compare
There was a problem hiding this comment.
Comment enhancement suggestions only. Makes it easier to understand, I hope :)
You tested the xtoken transfer & the HRMP channel, correct? Or should I test this as well?
If it's not too much work (if possible at all), would it be possible to shortly describe in the PR description from where you got your information from? Might come in handy in the future.
Co-authored-by: haerdib <73821294+haerdib@users.noreply.github.com>
Co-authored-by: haerdib <73821294+haerdib@users.noreply.github.com>
Co-authored-by: haerdib <73821294+haerdib@users.noreply.github.com>
|
| type ExecuteXcmOrigin = EnsureXcmOrigin<Origin, LocalOriginToLocation>; // Allow any local origin in XCM execution. | ||
| type XcmExecuteFilter = Nothing; // Disable generic XCM execution. This does not affect Teleport or Reserve Transfer. |
There was a problem hiding this comment.
Just for my understanding, is the combination of these two lines exactly the same as?
type ExecuteXcmOrigin = EnsureXcmOrigin<Origin, ()>; // Allow any local origin in XCM execution.
//^^^ changed the line here
type XcmExecuteFilter = Nothing; // Disable generic XCM execution. This does not affect Teleport or Reserve Transfer.Or would this also disable Teleport and Reserve Transfer then?
There was a problem hiding this comment.
From https://github.com/paritytech/polkadot/blob/99d6b557c0594a35198be84d03833e5af692d109/xcm/pallet-xcm/src/lib.rs#L86 , i think it would also disable Teleport and Transfer for users of this chain. ExecuteXcmOrigin is called in execute, do_reserve_transfer_assets and do_teleport_assets.
To undestand the different filter and check how to configure them: see https://blog.quarkslab.com/a-brief-overview-of-auditing-xcmv2.html
Tested: Filter changes still allow to manually open an HRMP channel with Acala's rococo parachain and transfer TEER token.