-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to polkadot v0.9.39 #205
Conversation
011e2bc
to
6968f0a
Compare
@@ -127,7 +126,6 @@ std = [ | |||
"pallet-child-bounties/std", | |||
"pallet-collective/std", | |||
"pallet-democracy/std", | |||
"pallet-randomness-collective-flip/std", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't exist anymore, but we did not use the pallet anyhow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
use xcm_transactor_primitives::*; | ||
|
||
const fn teer_general_key() -> Junction { | ||
const TEER_KEY: [u8; 32] = *b"TEER0000000000000000000000000000"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clangenb we found the cause of broken XCM ;-)
char '0' is hex 0x30, but should be 0x00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg, sorry for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blaming, just documenting ;-)
Contains the change to XCMV3: paritytech/cumulus#697.
The XCM migration is based upon https://github.com/PureStake/moonbeam/pull/2145/files.
Tests:
Follow-up tasks: