Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to polkadot v0.9.39 #205

Merged
merged 13 commits into from
May 17, 2023
Merged

bump to polkadot v0.9.39 #205

merged 13 commits into from
May 17, 2023

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented May 14, 2023

Contains the change to XCMV3: paritytech/cumulus#697.

The XCM migration is based upon https://github.com/PureStake/moonbeam/pull/2145/files.

Tests:

  • Test Block production of polkadot-launch setup

Follow-up tasks:

@clangenb clangenb marked this pull request as draft May 14, 2023 17:58
@clangenb clangenb marked this pull request as ready for review May 16, 2023 13:34
@clangenb clangenb force-pushed the cl/polkadot-v0.9.39 branch from 011e2bc to 6968f0a Compare May 16, 2023 13:49
@clangenb clangenb requested review from coax1d and OverOrion and removed request for coax1d May 16, 2023 14:14
@clangenb clangenb changed the title polkadot v0.9.39 bump to polkadot v0.9.39 May 16, 2023
@clangenb clangenb requested a review from coax1d May 16, 2023 14:15
@@ -127,7 +126,6 @@ std = [
"pallet-child-bounties/std",
"pallet-collective/std",
"pallet-democracy/std",
"pallet-randomness-collective-flip/std",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't exist anymore, but we did not use the pallet anyhow.

Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@clangenb clangenb merged commit 6b31725 into master May 17, 2023
@clangenb clangenb deleted the cl/polkadot-v0.9.39 branch May 17, 2023 13:18
use xcm_transactor_primitives::*;

const fn teer_general_key() -> Junction {
const TEER_KEY: [u8; 32] = *b"TEER0000000000000000000000000000";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clangenb we found the cause of broken XCM ;-)
char '0' is hex 0x30, but should be 0x00

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, sorry for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blaming, just documenting ;-)

@brenzi brenzi mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants