This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Rework #45
Open
Rework #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 28, 2017 17:51
Left over from older changes. Signed-off-by: Rodrigo Chiossi <rodrigo.chiossi@intel.com>
Using the plugin to set visualisation flags was a workaround needed for older gazebo versions. With gazebo 8, having only the control target is enough to manipulate the target in the UI and get the drone to properly fly to the target. Signed-off-by: Rodrigo Chiossi <rodrigo.chiossi@intel.com>
ctrl_targ doesn't represents what this model does, so this patch changes it to a more user friendly name. Signed-off-by: Rodrigo Chiossi <rodrigo.chiossi@intel.com>
|
What is the status on this? Most of changes look good to go, but I dont know about the status of the mentioned changes on other repos. |
|
I found a side effect on removing the VIS plugin when testing with simple_office.sdf in libcoav. The target can now trigger a detour and lock the vehicle in a loop around the destination. I'll testing some alternatives to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still working on this one. After this refractory patches, we will need to also change some things on our test maps in libcoav, so I may hold on on these for a while and merge it all together.