Skip to content

Commit

Permalink
[SYCL] Update ABI check for Ubuntu 22 differences (#7446)
Browse files Browse the repository at this point in the history
__libc_csu_init and __libc_csu_fini are not included anymore in the
binary. See more detailed comment inlined.
  • Loading branch information
Pavel Chupin authored Nov 18, 2022
1 parent b1533c5 commit 26619e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sycl/test/tools/abi_check_positive_dump.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
__libc_csu_fini
__libc_csu_init
_start
_Z3foov
main
7 changes: 7 additions & 0 deletions sycl/tools/abi_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ def parse_readobj_output(output):
# is used. Ignore it for the purpose of the library ABI check.
ignore_symbols = ["_dl_relocate_static_pie"]

# Starting from glibc 2.34 these symbols are not present anymore in the binary
# Ignoring these in case older glibc is used.
# Note that Ubuntu 20 has glibc 2.31 and Ubuntu 22 has glibc 2.35
# See: https://github.com/bminor/glibc/commit/035c012e32c11e84d64905efaf55e74f704d3668
ignore_symbols += ["__libc_csu_fini",
"__libc_csu_init"]

# In some scenarios MSVC and clang-cl exhibit differences in regards to the exported symbols they generate.
# Some of them happen in the SYCL RT library and we think clang-cl's behavior is more reasonable.
#
Expand Down

0 comments on commit 26619e0

Please sign in to comment.