Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Sema sycl-dllimport-dllexport test failed after community changes #2758

Closed
vmaksimo opened this issue Nov 10, 2020 · 0 comments · Fixed by #4842
Closed

[SYCL] Sema sycl-dllimport-dllexport test failed after community changes #2758

vmaksimo opened this issue Nov 10, 2020 · 0 comments · Fixed by #4842
Assignees
Labels
bug Something isn't working

Comments

@vmaksimo
Copy link
Contributor

The issue is found during the pulldown (PR #2745), regression is caused by ff2e24a.
Looks like we expect dllexport/dllimport attributes to be not supported, but they are just ignored as unknown ones.

/localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/clang/test/SemaSYCL/sycl-dllimport-dllexport.cpp:22:11: error: CHECK: expected string not found in input
// CHECK: warning: __declspec attribute 'dllexport' is not supported
          ^
<stdin>:1:1: note: scanning from here
/localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/clang/test/SemaSYCL/sycl-dllimport-dllexport.cpp:32:7: warning: unknown attribute 'dllimport' ignored [-Wunknown-attributes]
^
<stdin>:1:117: note: possible intended match here
/localdisk2/sycl_ci/buildbot/worker/sycl-ubu-x64-pr/llvm.src/clang/test/SemaSYCL/sycl-dllimport-dllexport.cpp:32:7: warning: unknown attribute 'dllimport' ignored [-Wunknown-attributes]

Surprisingly, it failed on both Linux and Win, although the change seems to have support of these attributes on Windows.
I'll mark the test with XFAIL until further fix.

vmaksimo added a commit to vmaksimo/llvm that referenced this issue Nov 10, 2020
@AlexeySachkov AlexeySachkov added the bug Something isn't working label Feb 2, 2021
Fznamznon added a commit to Fznamznon/llvm that referenced this issue Oct 28, 2021
The test was XFAIL-ed after pulldown some time ago.
This fixes intel#2758
dm-vodopyanov pushed a commit that referenced this issue Nov 12, 2021
The test was XFAIL-ed after pulldown some time ago.
This fixes #2758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants