Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix diagnostic about non-external function/variable #15372

Merged
merged 1 commit into from
Sep 20, 2024

Commits on Sep 12, 2024

  1. [SYCL] Fix diagnostic about non-external function/variable

    We were issuing a diagnostic when applying attributes like [[sycl_device]]
    or [[intel::device_indirectly_callable]] on functions/variables without
    external linkage - but the diagnostic text assumed that this occurred
    only with static entities or entities within unnamed namespaces.
    
    The following example demonstrates a case where the previous
    diagnostic text was misleading:
    
    ```
    namespace {
      struct S {};
    }
    
    [[sycl_device]] void foo(S);
    ```
    premanandrao committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    af5188a View commit details
    Browse the repository at this point in the history