LLVM and SPIRV-LLVM-Translator pulldown (WW45 2024) #16022
Conversation
Add Integral::toAPInt(), which truncates to the given BitWidth, similar to the toAPSInt() we already have.
Otherwise the shell might expand this in the command line.
/llvm-project/llvm/lib/Target/ARM/ARMFrameLowering.cpp:1028:9:
error: unused variable 'FPOffset' [-Werror,-Wunused-variable]
int FPOffset = MFI.getObjectOffset(FramePtrSpillFI);
^
1 error generated.
/llvm-project/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:302:14:
error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(llvm::errorCodeToError(Err));
^
/llvm-project/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:302:14: note: remove std::move call here
return std::move(llvm::errorCodeToError(Err));
^~~~~~~~~~ ~
1 error generated.
- Pass optimizes memcpy's by padding out destinations and sources to a full word to make backend generate full word loads instead of loading a single byte (ldrb) and/or half word (ldrh). Only pads destination when it's a stack allocated constant size array and source when it's constant array. Heuristic to decide whether to pad or not is very basic and could be improved to allow more examples to be padded. - Pass works within GlobalOpt but is disabled by default on all targets except ARM.
`S->isConsteval()` is evaluated at the top of this method. Likely mis-merging in #75425
Currently it is not an issue. It will be a problem if Bitmap is located after single byte counters.
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4885:13: warning: enumeration value 'SveMFloat8' not handled in switch [-Wswitch]
4885 | switch (llvm::cast<clang::BuiltinType>(qual_type)->getKind()) {
|
Fix #112593 by adding support in lowering to concatenation with an absent optional _assumed length_ dummy argument because: 1. Most compilers seem to support it (most likely by accident). 2. This actually makes the compiler codegen simpler. Codegen was going out of its way to poke the LLVM optimizer bear by producing an undef argument for the length. I insist on the fact that no compiler support this with _explicit length_ optional arguments and the executable will segfault and I would discourage users from using that "feature" because runtime checks for bad optional dereference will kick when used (For instance, "nagfor -C=present" will produce an executable that abort with an error message . Flang does not have such runtime check option so far). Hence, I am not updating the Extensions.md document because this is not something I think we should advertise.
llvm/llvm-project#112693 will be tracking the overall state of LoongArch support. This means anyone can check without having to track down an expert.
/llvm-project/polly/lib/CodeGen/LoopGeneratorsKMP.cpp:396:15: error: unused variable 'IdentTy' [-Werror,-Wunused-variable]
StructType *IdentTy =
^
/llvm-project/polly/lib/CodeGen/LoopGeneratorsKMP.cpp:460:15: error: unused variable 'IdentTy' [-Werror,-Wunused-variable]
StructType *IdentTy =
^
2 errors generated.
…mpt to constant fold Don't rely on isConstantIntBuildVectorOrConstantInt followed by getNode() will constant fold - FoldConstantArithmetic will do all of this for us. Cleanup for #112682
…mpt to constant fold Don't rely on isConstantFPBuildVectorOrConstantFP followed by getNode() will constant fold - FoldConstantArithmetic will do all of this for us. Cleanup for #112682
Returns true for shouldMaximizeVectorBandwidth when the register type is a scalable vector and SVE or streaming SVE are available.
…RM (#109628) The -mno-omit-leaf-frame-pointer flag works on 32-bit ARM architectures and addresses the bug reported in #108019
Add a helper for shared folds between logical and bitwise and/or and move the and/or of icmp and fcmp folds in there. This makes it easier to extend to more folds. A possible extension would be to base the current and/or of icmp reassociation logic on this helper, so that it for example also applies to fcmp.
Reverts llvm/llvm-project#107120 Unexpected build failures in post-commit pipelines. Needs investigation
…nsigned (#112642) Alive2: https://alive2.llvm.org/ce/z/6cqdt-
[Here](https://github.com/llvm/llvm-project/blob/6a98c4a1602591c942f01dceb3aa29ffd4cf1e5b/clang/include/clang/ASTMatchers/ASTMatchers.h#L4188-L4203) and [here](https://github.com/llvm/llvm-project/blob/6a98c4a1602591c942f01dceb3aa29ffd4cf1e5b/clang/include/clang/ASTMatchers/ASTMatchers.h#L3679-L3695) we can see similar code samples and same examples: ``` cxxMemberCallExpr(on(callExpr())) ``` In the first case, it is [written](https://github.com/llvm/llvm-project/blob/6a98c4a1602591c942f01dceb3aa29ffd4cf1e5b/clang/include/clang/ASTMatchers/ASTMatchers.h#L4201) that the object must not be matched: ``` /// cxxMemberCallExpr(on(callExpr())) /// does not match `(g()).m()`, because the parens are not ignored. ``` In the second case, it is [written](https://github.com/llvm/llvm-project/blob/6a98c4a1602591c942f01dceb3aa29ffd4cf1e5b/clang/include/clang/ASTMatchers/ASTMatchers.h#L3693) that the object must be matched: ``` /// cxxMemberCallExpr(on(callExpr())) /// matches `(g()).m()`. ``` I think that parens are ignored
MULS adversely affects performance on many implementations. Where this is the case, we prefer not to shrink MUL to MULS.
The init args shape might change in the loop body and hence the pattern doesn't hold true.
|
This is ready for review.
|
|
This update shows an incompatibility with the version of oneAPI Construction Kit that is used for NativeCPU, which is currently not tested in CI ( |
Yes, the please test it by merging this branch to |
|
Github is acting up and not allowing me to approve/review changes. FE Changes LGTM. However, the following PRs are not FE PRs and require review from other components. The IR changes are due to LLVM passes IIUC [SYCL][Test] Update attributes in tests after 69a798a 095d49d @intel/dpcpp-cfe-reviewers |
Thanks @elizabethandrews ! @intel/dpcpp-tools-reviewers Can someone help to have a look at [SYCL][Test] Update attributes in tests after 69a798a 095d49d @intel/dpcpp-tools-reviewers |
I'm not a code owner of those files, but those changes LGTM.
That I would defer to @intel/sycl-matrix-reviewers, I'm not familiar enough with the topic. Strictly speaking, bitcast through union is UB. Either |
@intel/sycl-matrix-reviewers Can you comment on [SYCL] Use union to do bitcast after bif removal in 8be6b10 |
|
@intel/llvm-gatekeepers This is ready for merge. Can someone help to issue a "/merge"? Thanks |
|
/merge |
|
Wed 13 Nov 2024 02:45:28 PM UTC --- Start to merge the commit into sycl branch. It will take several minutes. |
|
Wed 13 Nov 2024 02:50:16 PM UTC --- Merge failed with error: Please check whether the PR is mergeable |
|
@jsji Uuuh, never seen that before. Does that mean we need to merge again? |
Let me check the mergeable state locally first. |
|
/merge |
|
Wed 13 Nov 2024 02:57:03 PM UTC --- Start to merge the commit into sycl branch. It will take several minutes. |
|
Wed 13 Nov 2024 03:01:59 PM UTC --- Merge failed with error: Please check whether the PR is mergeable |
@DoyleLi Can you help to check what is going on with the bot? The PR is certainly mergeable here. |
LLVM: llvm/llvm-project@7f2e937
SPIRV-LLVM-Translator: KhronosGroup/SPIRV-LLVM-Translator@cf697333b60d200