[Driver][SYCL] Support 64bit long double for SYCL GPU compilation #16441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #15852 |
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
jchlanda
force-pushed
the
jakub/nvptx_long_double_64
branch
from
70b83f9 to
689f9ac
Compare
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Looks like linux gen12 is experiencing some problems. |
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Dec 20, 2024
|
|
||
| // RUN: not %clangxx -c -fsycl -mlong-double-80 -target nvptx64-nvidia-cuda %s -### 2>&1 | FileCheck --check-prefix=CHECK-80-NVPTX %s | ||
| // CHECK-80-NVPTX: error: unsupported option '-mlong-double-80' for target 'nvptx64-nvidia-cuda' | ||
| // CHECK-80-NVPTX-NOT: clang{{.*}} "-triple" "-nvptx64-nvidia-cuda" {{.*}} "-mlong-double-80" |
There was a problem hiding this comment.
For all of these, I believe the expected option syntax is to use --target=x86_64-unknown-linux-gnu -fsycl-targets=nvptx64-nvidia-cuda. Use of --target=<triple> is preferred over -target <triple> moving forward.
There was a problem hiding this comment.
Done. I've only updated tests that I've added in this patch.
As a side note, it seems strange that sycl target triple option gets only one hyphen, both seem to be following the same pattern of:
hyphen[hyphen]target_name=triple
but end up spelled out differently:
--target=<triple>
vs:
-fsycl-targets=<triple>
jchlanda
force-pushed
the
jakub/nvptx_long_double_64
branch
from
689f9ac to
4388fec
Compare
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that
-mlong-double-64option is supported on HIP/Cuda.