[SYCL][PI/CL] Check device version/extensions rather than platform version/extensions #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
5cb6ca5 to
c0afeea
Compare
romanovvlad
reviewed
Sep 20, 2022
smaslov-intel
suggested changes
Sep 20, 2022
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
c0afeea to
a68d3bd
Compare
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
a68d3bd to
7d553c0
Compare
dakr
requested review from
romanovvlad and
smaslov-intel
and removed request for
smaslov-intel and
romanovvlad
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
4 times, most recently
from
98af518 to
fc5144c
Compare
romanovvlad
reviewed
Sep 23, 2022
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
2 times, most recently
from
ecf2a33 to
e3ca585
Compare
dakr
requested review from
romanovvlad and
smaslov-intel
and removed request for
smaslov-intel and
romanovvlad
romanovvlad
reviewed
Sep 26, 2022
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
e3ca585 to
8d69871
Compare
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
2 times, most recently
from
d7062c6 to
78f8344
Compare
romanovvlad
requested changes
Sep 27, 2022
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
78f8344 to
6f689c2
Compare
smaslov-intel
approved these changes
Sep 27, 2022
This commit adds helper functions to query OpenCL device and platform versions as well as device extensions. While this patch is mainly motivated by a subsequent patch that adds some necessary version and extension checks to piProgramCreate() it also cleans up a few other places doing such queries. While at it, fix the missing error handling querying device extensions in piDeviceGetInfo(). Signed-off-by: Danilo Krummrich <dakr@redhat.com>
There might be platforms where the supported device version is lower than the platform version or where not all devices do support the same extensions and hence some extensions supported by particular devices are not reported in the platform extensions. In particular for CL_PLATFORM_EXTENSIONS the OpenCL specification says: "[...] Each extension that is supported by all devices associated with this platform must be reported here." In "3.4.1 Mixed Version Support" the specification also says: "[...] The version returned corresponds to the highest version of the OpenCL specification for which the device is conformant, but is not higher than the platform version." Hence, check for the device version and extensions rather than the platform version and extensions in piProgramCreate(). Signed-off-by: Danilo Krummrich <dakr@redhat.com>
dakr
force-pushed
the
pi_cl_plat_to_dev
branch
from
6f689c2 to
5524e9f
Compare
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OpenCL backends currently piProgramCreate() queries the platform version (CL_PLATFORM_VERSION) and platform extensions (CL_PLATFORM_EXTENSIONS) to check whether we're capable of running on top of a particular OpenCL backend.
However, there might be platforms where the supported device version is lower than the platform version or where not all devices do support the same extensions and hence some extensions supported by a particular device are not reported in the platform extensions.
In particular for CL_PLATFORM_EXTENSIONS the OpenCL specification says: "[...] Each extension that is supported by all devices associated with this platform must be reported here."
In 3.4.1 Mixed Version Support the specification also says: "[...] The version returned corresponds to the highest version of the OpenCL specification for which the device is conformant, but is not higher than the platform version."
Hence, check for the device version and extensions rather than the platform version and extensions in piProgramCreate().