[Driver][SYCL] Fix issue using -fsycl-force-target with offload dependencies #7025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies When using performing offloading with archives, an additional clang-offload-deps step is taken that determines the device dependencies during the link. When using -fsycl-force-target, we need to be sure that the target in which the dependency information is associated with matches so the proper device objects are referenced and pulled out.
hchilama
approved these changes
Oct 11, 2022
|
@intel/llvm-gatekeepers, this should be ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using performing offloading with archives, an additional clang-offload-deps step is taken that determines the device dependencies during the link. When using -fsycl-force-target, we need to be sure that the target in which the dependency information is associated with matches so the proper device objects are referenced and pulled out.