[SYCL] Relax kernel bundle device check to allow descendent devices #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this related to oneapi-src/oneDPL#657 and KhronosGroup/SYCL-Docs#313 ? |
Change kernel_bundle_impl constructors to treat descendent devices of context members as valid in accordance with SYCL 2020.
sergey-semenov
force-pushed
the
relaxbundledevcheck
branch
from
12d0540 to
66e8f35
Compare
Looks related, but the discussion in the docs issue seems to be revolving around the question of passing a root device kernel bundle to a sub-device queue rather than whether descendent devices of context members can be passed along with that context to the kernel bundle constructor. The latter is explicitly stated in the spec when it lists exception cases for get_kernel_bundle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change kernel_bundle_impl constructors to treat descendent devices of context members as valid in accordance with SYCL 2020.