[SYCL] Support memory clock rate and memory bus width queries #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
changed the title
steffenlarsen
requested changes
Nov 16, 2022
| @@ -3180,7 +3180,40 @@ pi_result piDeviceGetInfo(pi_device Device, pi_device_info ParamName, | |||
| } | |||
| return ReturnValue(FreeMemory); | |||
| } | |||
| case PI_EXT_INTEL_DEVICE_INFO_MEMORY_CLOCK_RATE: { | |||
| // If there are no any memory modules then return 0. | |||
There was a problem hiding this comment.
Let's document this behavior in pi.h
There was a problem hiding this comment.
And in the .md too, and also explain what is returned when a device has multiple memories
There was a problem hiding this comment.
Updated pi.h and document.
|
|
||
| # Memory Clock Rate # | ||
|
|
||
| A new device descriptor will be added which will provide the maximum clock rate of device's global memory. |
There was a problem hiding this comment.
Suggested change
| A new device descriptor will be added which will provide the maximum clock rate of device's global memory. | |
| A new device descriptor is added which provides the maximum clock rate of device's global memory. |
?
smaslov-intel
suggested changes
Nov 16, 2022
smaslov-intel
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E test: intel/llvm-test-suite#1386