Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add support for sycl::ext::oneapi::property::queue::use_priority #7523

Merged
merged 14 commits into from
Nov 29, 2022
Merged

[SYCL] Add support for sycl::ext::oneapi::property::queue::use_priority #7523

merged 14 commits into from
Nov 29, 2022

Conversation

smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Nov 24, 2022 •
edited
Loading

Adds a new queue property (hint) for setting its priority in backends that support it.
Currently supported in Level Zero backend only and ignored for others.
Test: intel/llvm-test-suite#1414

Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

@smaslov-intel smaslov-intel requested review from a team as code owners November 24, 2022 02:27
@smaslov-intel smaslov-intel mentioned this pull request Nov 24, 2022
Merged
@smaslov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1414

@zjin-lcf
Copy link
Contributor

What does priority mean for a queue ? Thanks.

@al42and
Copy link
Contributor

al42and commented Nov 24, 2022

Are there plans for a feature test macro?

@smaslov-intel
Copy link
Contributor Author

Are there plans for a feature test macro?

Sure. Added in a10e2c7

@smaslov-intel smaslov-intel requested a review from a team as a code owner November 27, 2022 03:00
@smaslov-intel
Copy link
Contributor Author

What does priority mean for a queue ? Thanks.

I've added doc for the new property: https://github.com/intel/llvm/blob/6e884e0ce0e67d70417877a895d479fe06d14d74/sycl/doc/extensions/supported/sycl_ext_oneapi_queue_priority.asciidoc

@smaslov-intel
[SYCL] Add support for sycl::ext::oneapi::property::queue::use_priority
042d9cf 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
add symbols
e023104 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
print queue priority under ZE_DEBUG
5b5ba66 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
added feature test macro SYCL_EXT_ONEAPI_QUEUE_PRIORITY
3eeeca9 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
added extension doc
50a9feb 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
update sumbols from Release build
1c4d539 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
address comments on doc
02803cd 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
chmod
00d1678 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
change use_priority to priority_low and priority_high
8a25c46 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
chmod
9750e53 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
clang-format
a42dd40 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
add priority_normal
ae196c6 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
add abi symbols
b1e320c 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Contributor Author

@KseniyaTikhomirova , @againull : please review

againull
againull approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0 plugin changes look good to me.

KseniyaTikhomirova
KseniyaTikhomirova approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smaslov-intel
Copy link
Contributor Author

@gmlueck : please re-review

Apparently, the CUDA & ESIMD test failures are unrelated.

@smaslov-intel
[NFC] update doc with suggestions
721526b 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
gmlueck
gmlueck approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specification LGTM.

@smaslov-intel
Copy link
Contributor Author

@againull : please merge

The CUDA failures are unrelated:

Failed Tests (3):
SYCL :: BFloat16/bfloat16_builtins.cpp
SYCL :: Matrix/element_wise_wi_marray_legacy.cpp
SYCL :: Matrix/joint_matrix_tensorcores_legacy.cpp

@againull
Copy link
Contributor

againull commented Nov 29, 2022 •
edited
Loading

@againull : please merge

The CUDA failures are unrelated:

Failed Tests (3):
SYCL :: BFloat16/bfloat16_builtins.cpp
SYCL :: Matrix/element_wise_wi_marray_legacy.cpp
SYCL :: Matrix/joint_matrix_tensorcores_legacy.cpp

@smaslov-intel Per our agreement with the team we can't ignore unrelated failures and have to be sure that all unrelated failures are addressed via created trackers/issues or PRs.
These failures are expected to be addressed by - #7567 and intel/llvm-test-suite#1421.

@againull againull merged commit cdb09dc into sycl Nov 29, 2022
@pvchupin
Copy link
Contributor

@smaslov-intel, please address post-commit on Windows: https://github.com/intel/llvm/actions/runs/3577020965/jobs/6015526146

Failed Tests (1):
  SYCL :: abi/sycl_symbols_windows.dump

@pvchupin pvchupin deleted the qpriority branch November 30, 2022 21:40
smaslov-intel added a commit to smaslov-intel/llvm that referenced this pull request Nov 30, 2022
@smaslov-intel
[SYCL] Update Windows symbols with what's introduced in intel#7523
0dd378f 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel smaslov-intel mentioned this pull request Nov 30, 2022
Merged
@smaslov-intel
Copy link
Contributor Author

@smaslov-intel, please address post-commit on Windows: https://github.com/intel/llvm/actions/runs/3577020965/jobs/6015526146

Failed Tests (1):
  SYCL :: abi/sycl_symbols_windows.dump

Coming in #7600

pvchupin pushed a commit that referenced this pull request Nov 30, 2022
@smaslov-intel
[SYCL] Update Windows symbols with what's introduced in #7523 (#7600)
15917cb 
Fixes post-commit issue reported in
#7523 (comment)
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook left review comments

@againull againull againull approved these changes

@KseniyaTikhomirova KseniyaTikhomirova KseniyaTikhomirova approved these changes

@gmlueck gmlueck gmlueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@smaslov-intel @zjin-lcf @al42and @againull @pvchupin @Pennycook @gmlueck @KseniyaTikhomirova