Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Num_CPUs aux value #105

Closed
wants to merge 3 commits into from
Closed

Conversation

captain5050
Copy link
Contributor

Num_CPUs is special in that the # prefix is missing. It maps to the perf num_cpus_online literal.

Num_CPUs is special in that the # prefix is missing. It maps to the
perf num_cpus_online literal.
@captain5050 captain5050 requested a review from kliang2 as a code owner September 6, 2023 04:09
Copy link
Contributor

@kliang2 kliang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4.6-release I have has the # prefix with Num_CPUs.
Aux #Num_CPUs

If the # is missed in the latest version, I think it's better to fix the TMA rather than workaround in the script.

Broadwell-de follows broadwell for core events but broadwellx for
uncore. Prior to this patch the uncore_arb PMU was tried to be used,
however, it isn't present and uncore_cbox should be used. Rework how
this is done in the code, in find_form for Page_Walks_Utilization
force the BDX lookup. For lookups that result in UNC_ARB retry the
lookup using BDX as lookup order.
@captain5050
Copy link
Contributor Author

Closing as per Kan's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants