Remove tsx_cycles_per_elision metric from SPR #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The el-start event is from sysfs (not json) and isn't present on SPR. The tsx_cycles_per_elision metric uses the event so remove the metric on SPR. Switch from using cycles-t as the sysfs event indicator the metric will work to el-start in case HLE gets disabled but not TSX.
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Oct 26, 2023
Update alderlake and alderlaken events from v1.21 to v1.23 adding the changes from: intel/perfmon@8df4db9 intel/perfmon@846bd24 The tsx_cycles_per_elision metric is updated from PR: intel/perfmon#116 Signed-off-by: Ian Rogers <irogers@google.com>
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Oct 26, 2023
Update tsx_cycles_per_elision as per: intel/perfmon#116 Prefer the el-start event rather than cycles-t for detecting whether the metric will work as HLE may be disabled. Remove the metric from sapphirerapids that has no el-start event. Signed-off-by: Ian Rogers <irogers@google.com>
roxell
pushed a commit
to roxell/linux
that referenced
this pull request
Oct 30, 2023
Update alderlake and alderlaken events from v1.21 to v1.23 adding the changes from: intel/perfmon@8df4db9 intel/perfmon@846bd24 The tsx_cycles_per_elision metric is updated from PR: intel/perfmon#116 Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Edward Baker <edward.baker@intel.com> Cc: Zhengjun Xing <zhengjun.xing@linux.intel.com> Link: https://lore.kernel.org/r/20231026003149.3287633-1-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
roxell
pushed a commit
to roxell/linux
that referenced
this pull request
Oct 30, 2023
Update tsx_cycles_per_elision as per: intel/perfmon#116 Prefer the el-start event rather than cycles-t for detecting whether the metric will work as HLE may be disabled. Remove the metric from sapphirerapids that has no el-start event. Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Edward Baker <edward.baker@intel.com> Cc: Zhengjun Xing <zhengjun.xing@linux.intel.com> Link: https://lore.kernel.org/r/20231026003149.3287633-9-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The el-start event is from sysfs (not json) and isn't present on SPR. The tsx_cycles_per_elision metric uses the event so remove the metric on SPR. Switch from using cycles-t as the sysfs event indicator the metric will work to el-start in case HLE gets disabled but not TSX.