Updates for TMA 5.01 support #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it easier to identify the source of generally processing issues.
Previous assumed to be <model long name>_metricscore_perf.json this fails for files like arrowlake_metrics_lioncove_core_perf.json. Change to using a glob of files: <model long name>_metricscore_*perf.json
Make event name lookup case insensitive to match perf's behavior.
Fixups for newer models in TMA 5. Remove some no longer needed fix ups. Make power fixups applied for all models.
Make other parts of the metric checking more tolerant. Remove the metric simplification of the threshold.
Use the MTL core and package cstates.
Remove the "ignore" metrics but add special case hanling for the MUX metric's special threshold value.
captain5050
requested review from
kliang2 and
edwarddavidbaker
as code owners
Rewriting with regexps means the rewrites are sensitive to the expression being rewritten and not just the events. Switch to parsing the metric then walking the expression tree fixing the $PEBS events. Update test expectations as unnecessary brackets are removed during the conversion.
Update for new column headers and the renaming of bottleneck metrics.
Update metrics using TMA 5.01.
1perrytaylor
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the create_perf_json.py converter script adding support for TMA 5.01.