Removing label with policy deletion #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new enforceable interface divides out some of the behavior of the strategies allowing those strategies that are assessed and actioned in a timed loop - like deschedule - to be handled under a new interface that covers their enforcement and their cleanup when the underlying policy is deleted. Co-authored-by: togashidm <denisio.togashi@intel.com> Co-authored-by: killianmuldoon <killian.muldoon@intel.com>
togashidm
force-pushed
the
node-unlabeling
branch
from
74acbe3
to
dc8fc96
Compare
uniemimu
reviewed
Oct 12, 2021
| klog.V(2).InfoS(err.Error(), "component", "controller") | ||
| } | ||
| } | ||
| klog.V(2).InfoS(fmt.Sprintf("Remove the node label since the node was violating the policy %v", policyName), "component", "controller") |
There was a problem hiding this comment.
I think the part after "since" is confusing. Isn't this supposed to be removing "since the policy was deleted"
There was a problem hiding this comment.
sure, I replace it to "Remove the node label on policy %v deletion."
togashidm
force-pushed
the
node-unlabeling
branch
from
dc8fc96
to
298deb0
Compare
When a deschedule policy is deleted the violating nodes that were labeled as "violating" need to be removed. New unit test cases are created to test the issue and also testt the capability of the node being relabelled, after policy deletion.
togashidm
force-pushed
the
node-unlabeling
branch
from
298deb0
to
c704c73
Compare
tejasshahintel
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new enforceable interface divides out some of the behavior of the
strategies allowing those strategies that are assessed and actioned
in a timed loop - like deschedule - to be handled under a new
interface that covers their enforcement and their cleanup when
the underlying policy is deleted. This fix may address
issue #29. For instance, when a policy with
deschedule strategy is not deleted, the node that is labeled as "violating"
not allowing schedule on that node. This fix makes violating nodes that
were labeled as "violating" removed when the respective policy is deleted.