Fix handling of nil dontschedule strategy #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniemimu
reviewed
Feb 10, 2022
telemetry-aware-scheduling/pkg/telemetryscheduler/telemetryscheduler.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
fix/nil-dontschedule
branch
2 times, most recently
from
67beb64
to
1a6c0f8
Compare
togashidm
approved these changes
Mar 24, 2022
uniemimu
approved these changes
Mar 24, 2022
Correct handling when the dontschedule strategy is not defined This makes an undefined dontschedule strategy in a policy result in no filtering to the node list. Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
togashidm
force-pushed
the
fix/nil-dontschedule
branch
from
1a6c0f8
to
dfcfd58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct handling when the dontschedule strategy is not defined
This makes an undefined dontschedule strategy in a policy
result in no filtering to the node list.
Signed-off-by: killianmuldoon kmuldoon@vmware.com