Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

disable dax during mount #644

Open
pohly opened this issue May 18, 2020 · 1 comment
Open

disable dax during mount #644

pohly opened this issue May 18, 2020 · 1 comment
Labels
future needs to be fixed in some future release

Comments

@pohly
Copy link
Contributor

pohly commented May 18, 2020

Being able to disable dax may also be useful for testing the LVM mode with a volume group that is backed by normal disks. Such a volume group then needs to be set up beforehand on each node (i.e. cannot rely on our init containers), but I know that this works because I have done it for the GCE example. The need for a simple LVM driver has come up as part of kubernetes/enhancements#1353.
@pohly pohly added the future needs to be fixed in some future release label May 18, 2020
pohly added a commit to pohly/pmem-CSI that referenced this issue Nov 6, 2020
@pohly
test: check FSGroup support
9dab280 
This was broken for the default
FS (intel#644).
pohly added a commit to pohly/pmem-CSI that referenced this issue Nov 11, 2020
@pohly
deploy: fix FSGroup support when using default FS
3d3a588 
The PV must have the filesystem specified for Kubernetes < 1.20 to
apply the FSGroup support (a heuristic in
Kubernetes). external-provisioner >= 2.0.0 only adds that field if it
knows about the default FS.

Fixes: intel#644
(cherry picked from commit 2ba30ba)
pohly added a commit to pohly/pmem-CSI that referenced this issue Nov 11, 2020
@pohly
test: check FSGroup support
eede6d0 
This was broken for the default
FS (intel#644).

(cherry picked from commit 9dab280)
@pohly pohly reopened this Nov 17, 2020
@pohly
Copy link
Contributor Author

pohly commented Nov 17, 2020

Another reason why disabling -o dax may be useful is to support apps which just want to do traditional file IO.

-o dax = -o dax=always (see https://www.kernel.org/doc/Documentation/filesystems/dax.txt) enables DAX for all files, whether the application wants that or not. Without it, we get the default behavior (-o dax=inode) where DAX is not enabled by default, but still can be enabled per file or directory via FS_XFLAG_DAX.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
future needs to be fixed in some future release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pohly