Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator.reset does not wait for simulation to complete creating race condition #126

Closed
madhuriakella opened this issue May 26, 2022 · 0 comments · Fixed by #131
Closed

Simulator.reset does not wait for simulation to complete creating race condition #126

madhuriakella opened this issue May 26, 2022 · 0 comments · Fixed by #131
Assignees
@madhuriakella
Labels
bug Something isn't working

Comments

@madhuriakella
Copy link
Contributor

Describe the bug

The _simulationEndRequested after reset is not set for run loop causing simulation to keep running even after it was asked to be ended.

To Reproduce

Step 1) simulator.endSimulation()
Step 2) simulator.reset() before simulationHasEnded

Expected behavior

After we call reset the simulation is not running anymore.

Actual behavior

Previous simulation tries to run even after reset because it never ended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhuriakella madhuriakella

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@madhuriakella