Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement neq #148

Closed
mkorbel1 opened this issue Aug 17, 2022 · 2 comments · Fixed by #350
Closed

Implement neq #148

mkorbel1 opened this issue Aug 17, 2022 · 2 comments · Fixed by #350
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mkorbel1
Copy link
Contributor

Motivation

Equality checks with eq are simple, but you have to use ~...eq for not-equal-to. It would be nice to be able to do not-equal-to using neq.

Desired solution

Implement neq everywhere that eq exists (for values and signals).
@mkorbel1 mkorbel1 added enhancement New feature or request good first issue Good for newcomers labels Aug 17, 2022
@stephtancs
Copy link

could take this too

Sanchit-kumar added a commit to Sanchit-kumar/rohd that referenced this issue Apr 27, 2023
@Sanchit-kumar
Fix intel#148: Implemented neq
9651678
@mkorbel1
Copy link
Contributor Author

@stephtancs note @Sanchit-kumar has implemented this already here: #350

@mkorbel1 mkorbel1 linked a pull request Apr 28, 2023 that will close this issue
Fix #148: Implemented neq #350
Merged
mkorbel1 pushed a commit that referenced this issue May 1, 2023
@Sanchit-kumar
Fix #148: Implemented neq (#350)
8dc0971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #148: Implemented neq Sanchit-kumar/rohd
2 participants
@mkorbel1 @stephtancs