Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework script "run_coverage" #173

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Rework script "run_coverage" #173

merged 1 commit into from
Oct 5, 2022

Conversation

chykon
Copy link
Contributor

@chykon chykon commented Oct 5, 2022

Description & Motivation

The old script called the "format_coverage" command, which accessed the ".packages" file, which will be completely deprecated in Dart 2.19. Dart 2.18 requires either explicitly requesting the generation of ".packages" with a temporary flag, or removing the reference to the ".packages" file from the script.

The script has been rewritten in a more strict style that stops execution when an error occurs (the old script was executed on error to the end).

The location directory has also been changed to follow the packaging convention.

Related Issue(s)

No.

Testing

Run the script, wait for execution, open index.html

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No. I did not find any references to the old script in the code.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No.

Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

I tried your branch out locally and everything seems to work. I hadn't noticed the .packages change.

@mkorbel1 mkorbel1 merged commit 7e47eee into intel:main Oct 5, 2022
@chykon chykon deleted the refactor-coverage-script branch October 5, 2022 18:54
@chykon chykon mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants