Increase Dart SDK version #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chykon
commented
Oct 14, 2022
chykon
commented
Oct 14, 2022
mkorbel1
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Thank you for your contribution!
I believe this sort-of does break backwards compatibility since it requires users to upgrade their version of Dart installed to at least 2.18.0, but I think it's time to do so rather than sit at an old Dart version forever. The next release will upgrade minor version (major still 0), indicating potentially backwards compatibility issues, so that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
ROHD currently uses Dart version 2.14. It is proposed to upgrade the version to the latest actual - 2.18. Among the changes, I would especially like to highlight the
super parametersadded in 2.17, which allow writing more compact constructors.It also becomes possible to use
enhanced enums, the idea of using which was mentioned here - #124.After the version upgrade, it was necessary to use a
dart fixto apply the recommendations related to the new language features.Related Issue(s)
No.
Testing
After the changes, testing was launched, which was successfully completed.
Backwards-compatibility
No.
Documentation
No.