-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
250 fsm state diagram mermaid generator #251
250 fsm state diagram mermaid generator #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I really liked the example. Here are my suggestions:
@chykon the code looks a lot cleaner now 🤣. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I'm just learning how to do code reviews, so I'm sorry if I was not quite correct somewhere or pointed out very minor details. I hope that helped you look from the outside 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add oven_fsm.dart
to test/example_test.dart
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny notes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, awesome contribution, thank you!
Description & Motivation
It's easier if we can visualize the state diagram in the FSM from the implementation.
Related Issue(s)
Fix #250
Testing
Added unit test to make sure the diagram is generated and there the word "mermaid" inside the file.
Backwards-compatibility
Yes.
Documentation
Yes. Added the documentation.