Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VcdParser to handle more VCD files #260

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Feb 7, 2023

Description & Motivation

While ROHD generates relatively simple VCD files, other tools (like Icarus Verilog) take advantage of more features of VCD files. This PR upgrades the VcdParser utility in ROHD so that it can check a wider variety of VCD files. It's still pretty limited, but this helps.

Related Issue(s)

N/A

Testing

Added a new test on a VCD file generated by Icarus Verilog

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit a0aa8fe into intel:main Feb 7, 2023
@mkorbel1 mkorbel1 deleted the vcdparseupgrade branch February 7, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant