Optimize Set
s, Map
s, and Module.input
/output
get
ters
#347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
There are a variety of places where ordered
Set
s andMap
s are used when unordered would be fine and offer a slight performance boost that adds up since they are used in fundamental building blocks for designs. Replacing them with unordered versions can give a significiant performance boost.There are other places where
Module.input
andModule.output
are called during simulation execution. This requires aMap
lookup during execution, which is an unnecessary simulation-time performance penalty. Replacing theget
ters that calledinput
andoutput
with laze initialized variables (late final
) removes all of those penalties.This also removes some
input
s from the public API ofFlipFlop
that shouldn't have ever been there.Related Issue(s)
N/A
Testing
Existing tests cover it
Backwards-compatibility
Yes, public
get
ters removed fromFlipFlop
forclk
andd
. But nobody should have been using them, so more like a bug fix.Documentation
No