Simulation performance improvements for conditional assignments #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Benchmarking, profiling, and usage of recent changes in other designs revealed a few small optimizations that could be made to improve simulation performance when many conditional assignments are used.
WriteAfterReadException
no longer prints the signal name. This enables creating one singlestatic
function for all write-after-read violations rather than creating a new one during simulation for each signal guarded. The loss in debug visibility is minimal since signal names going into aConditional
are already often not well-named signals, and the full stack trace can provide much more detail.ConditionalAssign
was redundant overhead, so caching it saves some performance.Related Issue(s)
N/A
Testing
Existing tests cover functionality.
CombGuardFanoutBenchmark
demonstrated some measurable performance improvements with these changes.Backwards-compatibility
No
Documentation
No