Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue:#337 Added clog2 #361

Merged

Conversation

Sanchit-kumar
Copy link
Contributor

Description & Motivation

In SystemVerilog, $clog2 is a useful function. It is better to have clog2 as per #337

Testing

Added required test cases to

test/logic_value_test.dart
test/math_test.dart

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Yes. I have update the following documentations:

README.md
doc/tutorials/chapter_2/00_basic_logic.md

lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/modules/gates.dart Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Outdated Show resolved Hide resolved
@Sanchit-kumar Sanchit-kumar force-pushed the issue-337-add-clog2-functionality branch from 83a7a2f to 739ef9a Compare May 31, 2023 01:05
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close, this looks great, thank you! Very nice test suite here too

README.md Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the contribution!

@mkorbel1 mkorbel1 merged commit 15f0661 into intel:main Jun 5, 2023
@mkorbel1 mkorbel1 linked an issue Jun 20, 2023 that may be closed by this pull request
@mkorbel1 mkorbel1 mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clog2 functionality
2 participants