-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue:#337 Added clog2 #361
Merged
mkorbel1
merged 4 commits into
intel:main
from
Sanchit-kumar:issue-337-add-clog2-functionality
Jun 5, 2023
Merged
Issue:#337 Added clog2 #361
mkorbel1
merged 4 commits into
intel:main
from
Sanchit-kumar:issue-337-add-clog2-functionality
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
requested changes
May 17, 2023
Sanchit-kumar
force-pushed
the
issue-337-add-clog2-functionality
branch
from
May 31, 2023 01:05
83a7a2f
to
739ef9a
Compare
mkorbel1
requested changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close, this looks great, thank you! Very nice test suite here too
mkorbel1
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for the contribution!
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
In SystemVerilog, $clog2 is a useful function. It is better to have clog2 as per #337
Testing
Added required test cases to
Documentation
Yes. I have update the following documentations: