Cases #386
Merged
Cases #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
requested changes
Jun 20, 2023
mkorbel1
reviewed
Jul 14, 2023
mkorbel1
requested changes
Jul 25, 2023
mkorbel1
requested changes
Aug 1, 2023
mkorbel1
requested changes
Aug 1, 2023
|
Your markdown failure is my fault, fixing in #398 |
mkorbel1
requested changes
Aug 1, 2023
mkorbel1
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Implemented a shorthand for creating a Conditional and Case. This is for the scenario where it is needed to assign/create a signal based on a condition, similar to a mux. The output is a single
Logicsignal. The width of the output signal is optional and if not specified, is inferred from the width of the conditions.Related Issue(s)
Fix #304
Testing
Added 5 new testcases which test the expression and condition match as well as width mismatch exceptions.
Backwards-compatibility
No
Documentation
Yes, API docs