Make Simulator.endSimulation return a Future
#455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Sometimes when ending a simulation, you may want to wait for it to actually end. This PR makes
Simulator.endSimulationreturn aFuture<void>which is the same asSimulator.simulationEnded, saving some time and lines.Related Issue(s)
N/A
Testing
Added new test
Backwards-compatibility
Probably not, but you may get a lint warning depending on settings for unawaited futures, or you may get some behavior changes if you have things that behave differently on Futures vs voids.
Documentation
No