Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #377: assign a logic subset to logic (array) #456

Merged
merged 28 commits into from
Mar 6, 2024
Merged

Issue #377: assign a logic subset to logic (array) #456

merged 28 commits into from
Mar 6, 2024

Conversation

RPG-coder-intc
Copy link
Contributor

@RPG-coder-intc RPG-coder-intc commented Jan 4, 2024 •
edited
Loading

Description & Motivation

Logic array subset assign

Related Issue(s)

Issue #377

Testing

please see in logic_array_test.dart

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

mkorbel1
mkorbel1 requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple small things then I think we can merge it in

lib/src/selection.dart Outdated Show resolved Hide resolved
lib/src/signals/logic_array.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 requested changes Jan 18, 2024
View reviewed changes
lib/src/signals/logic_array.dart Outdated Show resolved Hide resolved
lib/src/signals/logic_array.dart Outdated Show resolved Hide resolved
test/logic_array_test.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 reviewed Feb 15, 2024
View reviewed changes
lib/src/exceptions/logic/signal_width_mismatch_exception.dart Outdated Show resolved Hide resolved
lib/src/signals/logic_array.dart Outdated Show resolved Hide resolved
test/logic_array_test.dart Show resolved Hide resolved
@RPG-coder-intc
Copy link
Contributor Author

RPG-coder-intc commented Feb 22, 2024 •
edited
Loading

@mkorbel1 This seems to come from CI/CD main?

ERROR: 1 dead links found!
[✖] https://stackoverflow.com/ → Status: 403

RPG-coder-intc
RPG-coder-intc commented Feb 22, 2024
View reviewed changes
lib/src/signals/logic_array.dart Outdated Show resolved Hide resolved
test/logic_array_test.dart Show resolved Hide resolved
@mkorbel1
Copy link
Contributor

@mkorbel1 This seems to come from CI/CD main?

ERROR: 1 dead links found!
[✖] https://stackoverflow.com/ → Status: 403

Can you try updating this file to ignore it? I wonder if StackOverflow is blocking GitHub for some reason
.github/configs/mlc_config.json

mkorbel1
mkorbel1 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@RPG-coder-intc
Copy link
Contributor Author

@mkorbel1 can this be merged?

@mkorbel1
Copy link
Contributor

mkorbel1 commented Mar 6, 2024

@mkorbel1 can this be merged?

Yes, I thought it was already, my bad!

@mkorbel1 mkorbel1 merged commit 05f6cba into intel:main Mar 6, 2024
3 checks passed
@mkorbel1 mkorbel1 linked an issue Aug 2, 2024 that may be closed by this pull request
Write part-assign automation for LogicArrays #377
Closed
@mkorbel1 mkorbel1 mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write part-assign automation for LogicArrays
2 participants
@RPG-coder-intc @mkorbel1