Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Simulator error handling and end of simulation #515

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

There were cases where an error could occur during simulation and the simulation would not indicate that it had ended. This PR fixes those bugs and adds tests to cover those scenarios.

For example:

  • A registered action throws
  • Something calls Simulator.throwException
  • An end of simulation action throws

Related Issue(s)

N/A

Testing

Added new tests

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant